[Bug 781885] Do not rely on gl3ext.h being available when finding gl3.h

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu May 4 13:19:56 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=781885

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #351045|none                        |needs-work
             status|                            |

--- Comment #3 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 351045:
 --> (https://bugzilla.gnome.org/review?bug=781885&attachment=351045)

So, this could be made simpler by only checking/conditionalising for gl3ext.h
and moving the GLES2/gl2ext.h out of the else.  I don't think we need to
conditionalize gl2ext.h for GLES3.  It should always be there.

::: configure.ac
@@ +923,3 @@
+#   endif
+#   if $GLES3EXT2_H_DEFINE
+#     include <GLES3/gl2ext.h>

GLES2/gl2ext.h

or just remove the one below outside the #if and remove this check

@@ +1396,3 @@
+#   endif
+#   if $GST_GL_HAVE_GLES3EXT2_H
+#    include <GLES3/gl2ext.h>

ditto

::: gst-libs/gst/gl/gstglapi.h
@@ +46,3 @@
+#   endif
+#   if GST_GL_HAVE_GLES3EXT2_H
+#    include <GLES3/gl2ext.h>

ditto

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list