[Bug 773681] directsoundsink: High cpu usage on windows x86

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773681

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #351318|none                        |needs-work
             status|                            |

--- Comment #33 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 351318:
 --> (https://bugzilla.gnome.org/review?bug=773681&attachment=351318)

Generally a good change, thanks! This will make the waiting more granular, we
can wait sub-milliseconds with this.

::: sys/directsound/gstdirectsoundsink.c
@@ +670,3 @@
+
+      /* don't bother with the return value as we'll detect reset separately
*/
+      gst_clock_id_wait (clock_id, NULL);

You probably want to check the return value. This returns UNSCHEDULED if
unscheduled, making the additional reset_while_sleeping boolean useless
probably

@@ +673,3 @@
+
+      GST_DSOUND_LOCK (dsoundsink);
+      dsoundsink->clock_id = NULL;

Shouldn't this also get a gst_clock_id_unref()?

@@ +725,3 @@

+    hRes = IDirectSoundBuffer_Unlock (dsoundsink->pDSBSecondary,
pLockedBuffer1,
+        dwSizeBuffer1, pLockedBuffer2, dwSizeBuffer2);

Why do you move this around?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.