[Bug 782095] decodebin: Crash on shutdown with chained opus file

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=782095

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #351041|none                        |reviewed
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 351041:
 --> (https://bugzilla.gnome.org/review?bug=782095&attachment=351041)

::: gst/gstelement.c
@@ +828,3 @@
   GST_TRACER_ELEMENT_REMOVE_PAD (element, pad);
   gst_object_unparent (GST_OBJECT_CAST (pad));
+  GST_OBJECT_FLAG_UNSET (pad, GST_PAD_FLAG_NEED_PARENT);

Not sure if this is ok: the reason for that flag is to guarantee that the pad
functions are only ever called with the parent!=NULL, so that you don't get any
spurious calls with parent==NULL when the pad is just removed from the element.

So this would be exactly the case here...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.