[Bug 753275] Opus: playback gain always relative to EBU R128 level (-23db LUFS), must be played 5db louder to match ReplayGain level (-18db LUFS) when using ReplayGain

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753275

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #350789|none                        |needs-work
             status|                            |

--- Comment #18 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 350789:
 --> (https://bugzilla.gnome.org/review?bug=753275&attachment=350789)

::: gst/gsttaglist.c
@@ +409,3 @@
+  gst_tag_register_static (GST_TAG_R128_TRACK_GAIN, GST_TAG_FLAG_META,
+      G_TYPE_DOUBLE, _("EBU-128 replaygain track gain"),
+      _("EBU-128 track gain in db"), NULL);

It's called EBU-R128, or not?

::: gst/gsttaglist.h
@@ +1089,3 @@
+ * GST_TAG_R128_TRACK_GAIN:
+ *
+ * track gain in db using EBU-128 (double)

It's dB, not db

@@ +1090,3 @@
+ *
+ * track gain in db using EBU-128 (double)
+ */

Since: 1.14

@@ +1091,3 @@
+ * track gain in db using EBU-128 (double)
+ */
+#define GST_TAG_R128_TRACK_GAIN             "r128-track-gain"

ebu-r128-track-gain?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.