[Bug 781776] decklink: Detect gaps on incoming stream times, issue warnings

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=781776

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #351428|none                        |needs-work
             status|                            |

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 351428:
 --> (https://bugzilla.gnome.org/review?bug=781776&attachment=351428)

::: sys/decklink/gstdecklinkaudiosrc.cpp
@@ +36,3 @@
 #define DEFAULT_DISCONT_WAIT          (1 * GST_SECOND)
 #define DEFAULT_CHANNELS              (GST_DECKLINK_AUDIO_CHANNELS_2)
+#define DEFAULT_EXPECTED_STREAM_TIME (GST_CLOCK_TIME_NONE)

This is not a property, so does not need a #define here

@@ +38,3 @@
+#define DEFAULT_EXPECTED_STREAM_TIME (GST_CLOCK_TIME_NONE)
+
+#define ABSDIFF(x, y) ( (x) > (y) ? ((x) - (y)) : ((y) - (x)) )

#ifndef ABSDIFF
#define ABSDIFF ...
#endif

@@ +203,3 @@
   self->buffer_size = DEFAULT_BUFFER_SIZE;
   self->channels = DEFAULT_CHANNELS;
+  self->expected_stream_time = DEFAULT_EXPECTED_STREAM_TIME;

Need to reset this whenever capturing is (re)started

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.