[Bug 782221] jpeg2000parse does not play nice with rtpj2kpay

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=782221

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #351414|none                        |needs-work
             status|                            |

--- Comment #18 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 351414:
 --> (https://bugzilla.gnome.org/review?bug=782221&attachment=351414)

Generally good but:

::: gst/videoparsers/gstjpeg2000parse.c
@@ +200,3 @@
+  g_return_if_fail ((in_caps == NULL) || gst_caps_is_fixed (in_caps));
+
+  caps = gst_pad_get_allowed_caps (GST_BASE_PARSE_SRC_PAD (parse));

These are not unreffed in all code paths (if they are empty)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.