[Bug 781673] aggregator: always handle synchronized events on output thread

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=781673

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #351493|none                        |needs-work
             status|                            |

--- Comment #25 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 351493:
 --> (https://bugzilla.gnome.org/review?bug=781673&attachment=351493)

This seems to make sense.

::: gst-libs/gst/base/gstaggregator.c
@@ +444,3 @@

+    if (pad->priv->num_buffers == 0) {
+      if (g_queue_get_length (&pad->priv->buffers) != 0)

Maybe a premature optimization but could be replaced with
gst_aggregator_pad_queue_is_empty (pad) like in the original code.

@@ +486,3 @@
     GST_LOG_OBJECT (pad, "pad not ready to be aggregated yet");
     GST_OBJECT_UNLOCK (self);
+    return have_event;

The log message is not quite right here anymore

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.