[Bug 781673] aggregator: always handle synchronized events on output thread

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=781673

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #351498|none                        |reviewed
             status|                            |

--- Comment #30 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 351498:
 --> (https://bugzilla.gnome.org/review?bug=781673&attachment=351498)

This seems mostly sane.

I'm not exactly sure about the rationale for storing in the clipped_buffer
unless ->clip() is not idempotent and/or not deterministic.

::: gst-libs/gst/base/gstaggregator.c
@@ +2494,3 @@
+
+    if (self == NULL) {
+      self = GST_AGGREGATOR (gst_pad_get_parent_element (GST_PAD (pad)));

Why is this inside the loop?

Will the pad get a different parent while the PAD_LOCK is held?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.