[Bug 777641] pcapparse: add support of parsing by mac addresses and ethertype for raw ethernet frames.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=777641

Petr Nechaev <petr.nechaev at cogentembedded.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #344021|none                        |accepted-commit_now
             status|                            |

--- Comment #2 from Petr Nechaev <petr.nechaev at cogentembedded.com> ---
Review of attachment 344021:
 --> (https://bugzilla.gnome.org/review?bug=777641&attachment=344021)

These lines need to be removed: unnecessary style changes

-static gboolean gst_pcap_sink_event (GstPad * pad,
-    GstObject * parent, GstEvent * event);
+static gboolean gst_pcap_sink_event (GstPad * pad, GstObject * parent,
+    GstEvent * event);


guint should not be set to "-1": unnecessary code complexity
+  self->ethertype = -1;
Use larger int type if you need negative values.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.