[Bug 761439] Backward step operations fails and may lead to negative position value

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=761439

Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vincent.penquerch at collabora
                   |                            |.co.uk

--- Comment #14 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> ---
I think this looks wrong:

5890        GST_DEBUG ("Setting playback direction to %s at
%"G_GINT64_FORMAT"", DIRECTION_STR, cur);
5891        event = gst_event_new_seek (target_rate,
5892                    GST_FORMAT_TIME, GST_SEEK_FLAG_FLUSH |
GST_SEEK_FLAG_ACCURATE,
5893                    GST_SEEK_TYPE_SET, forward ? cur : G_GINT64_CONSTANT
(0),
5894                    GST_SEEK_TYPE_SET, forward ? G_GINT64_CONSTANT (0) :
cur);
5895        if (gst_element_send_event (bvw->priv->play, event) == FALSE) {
5896          GST_WARNING ("Failed to set playback direction to %s",
DIRECTION_STR);
5897        } else {
5898          gst_element_get_state (bvw->priv->play, NULL, NULL,
GST_CLOCK_TIME_NONE);
5899          bvw->priv->rate = target_rate;

In the seek event, if we're going forward, both start and stop are set, and the
segment is set from cur to 0. Should it not be from cur to something unset ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.