[Bug 743062] GstObject subclasses sinking instances in instance_init/constructor cause leaks in bindings

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=743062

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
The main problem here is that this will "break" every subclass of GstClock and
GstControlSource and GstTaskPool (and GstTask, GstBus, but who does that?).
The constructors of those subclasses would now have to unset the floating flag
instead, requiring some code to be added to every of these subclasses.

However the impact of this should be rather minimal, even if they don't get the
new ref_sink() added:
1) For C code this distinction rarely matters. All objects apart from control
sources never have a parent (they are not "added" to anything), and while
control sources are "added" to a control bindings, the bindings take a new
reference anyway so the control sources always stay floating. Only if someone
manually ref_sinks the control sources, there would be a problem.
2) For bindings it is broken anyway, see this bug

-- 
You are receiving this mail because:
You are the QA Contact for the bug.