[Bug 782648] heap-use-after-free in gst_debug_print_object() spotted by Asan

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=782648

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #351859|accepted-commit_now         |reviewed
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 351859:
 --> (https://bugzilla.gnome.org/review?bug=782648&attachment=351859)

::: gst/gstvalue.c
@@ +6436,3 @@
         g_strdup_printf ("(%s) %s", G_OBJECT_TYPE_NAME (obj),
         GST_OBJECT_NAME (obj));
+    GST_OBJECT_UNLOCK (obj);

This should not be needed as the object name is considered immutable. As long
as you have a reference to the object, it's not going to go away

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.