[Bug 747990] bin/element: gst_bin_add() and gst_element_add_pad() don't take reference in error cases

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon May 15 11:37:05 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=747990

--- Comment #16 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Created attachment 351880
  --> https://bugzilla.gnome.org/attachment.cgi?id=351880&action=edit
gst: Fix floating reference inconsistencies in error cases

If a function takes a floating reference and sinks it, it should also do
that in error cases. I.e. call ref_sink() followed by unref().

Otherwise the reference counting behaviour of the function will be
different between the good and the error case, and simply inconsistent.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.


More information about the gstreamer-bugs mailing list