[Bug 782695] alsa: Missing float PCM support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=782695

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #351975|none                        |reviewed
             status|                            |

--- Comment #1 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 351975:
 --> (https://bugzilla.gnome.org/review?bug=782695&attachment=351975)

Thanks, Looks good in general. Can you rework the commit message ? Something
like alsa: Add mapping for PCM F32/F64 formats . And in the long description,
I'd mention that this enables float pcm formats for both the alsasrc and
alsasink (your current message gives the impression this is only the sink).

::: ext/alsa/gstalsa.c
@@ +131,3 @@
+    case GST_AUDIO_FORMAT_F32BE:
+      return SND_PCM_FORMAT_FLOAT_BE;
+     /* 64 bit */

I think this comment is not needed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.