[Bug 781537] NVDEC - Nvidia Decoder plugin

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=781537

--- Comment #24 from Victor Toso <bugzilla at victortoso.com> ---
Review of attachment 351772:
 --> (https://bugzilla.gnome.org/review?bug=781537&attachment=351772)

Hi,

- I have a m2000 and K620 here with me so I plan to help out with testing as
much as possible.
- Do you have your code in some git to make it easier to review/test new
changes?
- This bug has duplicated patches, when you attach a new patch please mark the
older ones as obsolete :)

I tried building this, I have installed cuda-8.0, I hope this is correct!
Warnings:

gstnvh264dec.c: In function ‘pop_cuda_ctx’:
gstnvh264dec.c:160:24: error: passing argument 1 of ‘cuCtxPopCurrent_v2’ from
incompatible pointer type [-Werror=incompatible-pointer-types]
       cuCtxPopCurrent (pnvh264dec->cuda_ctx));

gstnvh264dec.c: In function ‘gst_nvh264dec_handle_picture_decode’:
gstnvh264dec.c:314:3: error: ISO C90 forbids mixed declarations and code
[-Werror=declaration-after-statement]
   gboolean is_ok = IS_CUDA_CALL_SUCCSESS (nvh264dec,
   ^~~~~~~~

gstnvh264dec.c:153:1: error: ‘pop_cuda_ctx’ defined but not used
[-Werror=unused-function]
 pop_cuda_ctx (GstNvh264dec * nvh264dec)
 ^~~~~~~~~~~~

pop_cuda_ctx() seems to be commented out for some reason and seems that you can
fix the first one by passing &pnvh264dec->cuda_ctx

I hope to provide better feedback later this week.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.