[Bug 776927] gl: gldownload: convert GstGLMemory to GstDmaBuf

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776927

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #352051|none                        |needs-work
             status|                            |

--- Comment #35 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 352051:
 --> (https://bugzilla.gnome.org/review?bug=776927&attachment=352051)

This looks mostly fine, a couple of issues below.

::: ext/gl/gstgldownloadelement.c
@@ +113,3 @@
+  features = gst_caps_get_features (out_caps, 0);
+  if (gst_caps_features_contains (features, GST_CAPS_FEATURE_MEMORY_DMABUF)) {
+    download->dmabuf_allocator = gst_dmabuf_allocator_new ();

You don't free this anywhere.

::: gst-libs/gst/gl/egl/gsteglimage.c
@@ +518,3 @@
+        "Failed to retrieve GstGLDisplayEGL from %" GST_PTR_FORMAT,
+        image->context->display);
+    return EGL_NO_IMAGE_KHR;

return FALSE;

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.