[Bug 782778] New: Alignement of input caps no longer set to a default value

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=782778

            Bug ID: 782778
           Summary: Alignement of input caps no longer set to a default
                    value
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: wiwright at tycoint.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

In the following change the 'handling of input caps corner cases for the
h264parse element" was tidied up.

https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/gst/videoparsers/gsth264parse.c?h=1.4&id=ea7d5027a079fad397b0ad97a0be48c69121e30e

Although not sure, I believe that there may have been an unintended behavioural
change with the above submission.

Prior to the submission, when the stream format was not specified in the input
caps the local 'format' variable was assigned a default value of
GST_H264_PARSE_FORMAT_BYTE and the local 'alignment' variable was assigned a
default value of GST_H264_PARSE_ALIGN_AU.

After the submission when the stream format was not specified in the input caps
the local 'format' variable was assigned a default value of
GST_H264_PARSE_FORMAT_BYTE and the local 'alignment' variable was left
unchanged.

When 'format' is given a default value, should alignement be given a value that
is appropriate for the chosen default stream format?  Not doing so, can result
in unexpected behaviour of the gst_h264_parse_negotiate() method that
gst_h264_parse_set_caps() calls

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.