[Bug 782652] ges: Correctly handling floating references

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=782652

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tsaunier at gnome.org

--- Comment #4 from Thibault Saunier <tsaunier at gnome.org> ---
(In reply to Sebastian Dröge (slomo) from comment #3)
> Review of attachment 351879 [details] [review]:
> 
> ::: ges/ges-timeline-element.c
> @@ +543,2 @@
>    self->parent = parent;
> +  gst_object_ref_sink (self);
> 
> This breaks the unit tests (and causes leaks), because at least sometimes
> something else already removed the floating reference flag and then this now
> increases the reference count.
> 
> What to do?

I changed the doc as it was wrong, ownership for GESTimelineElement is either
the timeline (for clips or groups), or the Track for GESTrackElement.

The parent owns a hard ref.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.