[Bug 782878] New: audioaggregator: Drop object locks while calling aggregate_one_buffer vfunc

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sat May 20 17:10:33 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=782878

            Bug ID: 782878
           Summary: audioaggregator: Drop object locks while calling
                    aggregate_one_buffer vfunc
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: olivier.crete at ocrete.ca
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Right now, the audioaggregator calls hold the object locks for both pad and
element object locks while calling the ->aggregate_one_buffer() vfunc. The
attached patch just drops the locks while calling it. There is a little
performance penalty, but I think it's worth it for correctness. Please yell if
you disagree or I'll merge it soonish.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list