[Bug 746529] videoaggregator: Adding support for downstream allocation negotiation

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sat May 20 17:11:12 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=746529

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #352230|none                        |needs-work
             status|                            |

--- Comment #10 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 352230:
 --> (https://bugzilla.gnome.org/review?bug=746529&attachment=352230)

.

::: gst-libs/gst/base/gstaggregator.c
@@ +2976,3 @@
+ * used
+ * @params: (out) (allow-none) (transfer full): the
+ * #GstAllocationParams of @allocator

erm, this isn't transfer full in the code

::: gst-libs/gst/base/gstaggregator.h
@@ +209,3 @@
  *                       Notifies subclasses what caps format has been
negotiated
+ * @decide_allocation: Optional.
+ *                     Allows the subclass to influence the allocation
choices.

Extend the comment with some inspiration from
GstBaseTransform::decide_allocation?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list