[Bug 732874] audioencoder: Baseclass should call set_format() before propose_allocation()

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=732874

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|videoencoder: Baseclass     |audioencoder: Baseclass
                   |should call set_format()    |should call set_format()
                   |before propose_allocation() |before propose_allocation()

--- Comment #3 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
This has been done for the encoder in 2014.

commit ce50fc221e8a795d7cfedf471d239d4a9d3bf824
Author: Nicolas Dufresne <nicolas.dufresne at collabora.com>
Date:   Tue Jul 8 16:59:37 2014 -0400

    videoencoder: Don't delay set_format

    This prevent implementing allocation query, as the format need to be
    known in order to determin the size and number of buffers needed.

    Note: This may lead to few regressions that will need fixing

    https://bugzilla.gnome.org/show_bug.cgi?id=732288

So only the audio encoder got this behaviour now. I would believe it's less of
a problem as the allocation in audio is not as dependant on the caps as it is
for video. Shall we keep that bug open ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.