[Bug 770107] qtdemux: reports only one encryption system even if it can support more than one

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=770107

Enrique Ocaña González <eocanha at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #352262|needs-work                  |none
             status|                            |
 Attachment #352262|0                           |1
        is obsolete|                            |

--- Comment #24 from Enrique Ocaña González <eocanha at igalia.com> ---
Created attachment 352311
  --> https://bugzilla.gnome.org/attachment.cgi?id=352311&action=edit
2/3 qtdemux: add context for a preferred protection (review suggestions
applied)

Applied the review suggestions except the event queues backward walking
(Calvaris commented the rationale of iterating backwards) and the lack of
locking.

We discussed in person about this lack of locking and realized that
gst_qtdemux_set_context() could actually be called from any thread (eg: by the
application from the main thread, not just by qtdemux in the streaming thread)
and that's why some locking on the object (on qtdemux) would be needed.
However, locks aren't recursive and it's not clear how we would detect if
recursion is happening and the lock is already acquired. The summary of the
discussion was to forget about locking by now and just assume that the only
caller of gst_qtdemux_set_context() will be the streaming thread.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.