[Bug 775948] omxvideodec: Support for egl_render on RPi breaks dynamic resolution changes

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775948

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julien.isorce at gmail.com

--- Comment #6 from Julien Isorce <julien.isorce at gmail.com> ---
Hi minfrin, thx a lot for your investigations. In comment 4 I think Sebastian
was talking about the other fallback (see comment 3), not the software
fallback.

Could you split your patch in 2, one that just remove the 'accelerated'
fallback case mentioned in comment 3 (I think you are right and it should be
safe to remove it now, we left at the time we merged eglglessink into
glimagesink few years ago, and when caps feature was not set depending on the
gstgl versions used), and one patch that records the color format, because I
think it is different problems.
Then could you try to check if the 'color format' patch alone fixes the
transcoding issue your reported in comment 0 ?

If yes then the problem is that the dec_output_port has lost its initial color
format after the 'tunnel' being disconnected
(https://cgit.freedesktop.org/gstreamer/gst-omx/tree/omx/gstomxvideodec.c#n1094).
So indeed we should record this color format at the beginning, like you did.

Also it looks the issue tracker title does not match the comment 0, it should
be "omxvideodec: Support for egl_render on RPi breaks negotiation with
omxh264enc", something like that.

(In reply to minfrin from comment #5)
> This patch also fixed the problem in
> https://bugzilla.gnome.org/show_bug.cgi?id=767801.
It is not entirely exact, the real problem in that other tracker issue is the
failure of the first 'accelerated' negotiation:
https://cgit.freedesktop.org/gstreamer/gst-omx/tree/omx/gstomxvideodec.c#n956
With the first patch of the split mentioned above, it will still switch back to
use system memory like reported in comment 0
https://bugzilla.gnome.org/show_bug.cgi?id=767801#c0 . That said I still think
we need both of the 2 patches I mentioned above. First one for cleanup, second
to fix transcoding. 

Thx!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.