[Bug 777825] isoff: Move isoff to gst-libs

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue May 23 20:50:08 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=777825

Reynaldo H. Verdejo Pinochet <reynaldo at osg.samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #352066|none                        |needs-work
             status|                            |

--- Comment #28 from Reynaldo H. Verdejo Pinochet <reynaldo at osg.samsung.com> ---
Review of attachment 352066:
 --> (https://bugzilla.gnome.org/review?bug=777825&attachment=352066)

Almost there, two nits though:

::: gst-libs/gst/isoff/gstisoff.c
@@ +40,3 @@
+  }
+
+/* gst_isoff_parse_box:

Wrong name, not vital but please fix if you are uploading a new iteration

::: tests/check/Makefile.am
@@ +261,3 @@
     elements/h263parse \
     elements/h264parse \
+    elements/isoff \

Non element-specfic isoff tests should
probably be in libs/ Please double check
and adjust accordingly.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list