[Bug 783038] timecodestamper: Always increment internal counter

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783038

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #352486|none                        |reviewed
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 352486:
 --> (https://bugzilla.gnome.org/review?bug=783038&attachment=352486)

::: gst/timecode/gsttimecodestamper.c
@@ +425,3 @@
     GST_OBJECT_UNLOCK (timecodestamper);
     tc = gst_video_time_code_copy (&tc_meta->tc);
+    gst_video_time_code_increment_frame (timecodestamper->current_tc);

Wouldn't it be better to update current_tc with the one from the meta, instead
of blindly incrementing?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.