[Bug 777825] isoff: Move isoff to gst-libs

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu May 25 09:32:35 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=777825

--- Comment #32 from Seungha Yang <sh.yang at lge.com> ---
(In reply to Reynaldo H. Verdejo Pinochet from comment #28)
> Review of attachment 352066 [details] [review]:
> 
> Almost there, two nits though:
> 
> ::: gst-libs/gst/isoff/gstisoff.c
> @@ +40,3 @@
> +  }
> +
> +/* gst_isoff_parse_box:
> 
> Wrong name, not vital but please fix if you are uploading a new iteration

Sorry for late reply. I fixed it.

> 
> ::: tests/check/Makefile.am
> @@ +261,3 @@
>  	elements/h263parse \
>  	elements/h264parse \
> +	elements/isoff \
> 
> Non element-specfic isoff tests should
> probably be in libs/ Please double check
> and adjust accordingly.

I think moving it into libs seems correct, and did it on new patch set.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list