[Bug 783075] adaptivedemux: Check live seeking range more often

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu May 25 14:17:39 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=783075

--- Comment #3 from Edward Hervey <bilboed at bilboed.com> ---
Review of attachment 352556:
 --> (https://bugzilla.gnome.org/review?bug=783075&attachment=352556)

::: gst-libs/gst/adaptivedemux/gstadaptivedemux.c
@@ +4145,3 @@
+  if (demux->segment.rate != 1.0 && gst_adaptive_demux_is_live (demux)) {
+    if (!gst_adaptive_demux_stream_in_live_seek_range (demux, stream))
+      ret = GST_FLOW_EOS;

How so ?

* If you're doing negative rates it's not going to help (you're already outside
of the seek range and it's not going to ever go backwards).
* If you're doing positive rates ... you're not playing at the same speed at
which the "live" position (and therefore seekable range) moves anyway. Would
you want it to constantly buffer/pause ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list