[Bug 778732] Encoders: add VBR feature for AVC/VP8/HEVC/VP9

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=778732

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #352507|none                        |needs-work
             status|                            |

--- Comment #6 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 352507:
 --> (https://bugzilla.gnome.org/review?bug=778732&attachment=352507)

::: gst-libs/gst/vaapi/gstvaapiencoder_vp8.c
@@ +224,3 @@

+  if (GST_VAAPI_ENCODER_RATE_CONTROL (encoder) & GST_VAAPI_RATECONTROL_CBR ||
+      GST_VAAPI_ENCODER_RATE_CONTROL (encoder) & GST_VAAPI_RATECONTROL_VBR)

This is wrong: GstVaapiRateControl is not a bitwise enum, is a normal enum. So
no bitwise operations are allowed

@@ +271,3 @@

+  if (GST_VAAPI_ENCODER_RATE_CONTROL (encoder) != GST_VAAPI_RATECONTROL_CBR &&
+      GST_VAAPI_ENCODER_RATE_CONTROL (encoder) != GST_VAAPI_RATECONTROL_VBR)

why not just

if (GST_VAAPI_ENCODER_RATE_CONTROL (encoder) == GST_VAAPI_RATECONTROL_CQP)
  return;

??

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.