[Bug 766832] encoder: Add CBR and VBR support in VP9

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766832

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #352508|none                        |reviewed
             status|                            |

--- Comment #4 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 352508:
 --> (https://bugzilla.gnome.org/review?bug=766832&attachment=352508)

::: gst-libs/gst/vaapi/gstvaapiencoder_vp9.c
@@ +310,3 @@
+    memset (rate_control, 0, sizeof (VAEncMiscParameterRateControl));
+    rate_control->bits_per_second = encoder->bitrate_bits;
+    rate_control->target_percentage = 70;

same thing of the target_percentage as I mentioned in bug 778732

@@ +313,3 @@
+    rate_control->window_size = encoder->cpb_length;
+    rate_control->initial_qp = encoder->yac_qi;
+    rate_control->min_qp = 1;   /* Fixme: provide user control */

I not sure if 1 is a good "default". vp9enc uses 0. Also ffmpeg, if I
understand correctly.

@@ +314,3 @@
+    rate_control->initial_qp = encoder->yac_qi;
+    rate_control->min_qp = 1;   /* Fixme: provide user control */
+    rate_control->basic_unit_size = 0;

not required size memset is set to zero

@@ +551,3 @@
   encoder->sharpness_level = DEFAULT_SHARPNESS_LEVEL;
   encoder->yac_qi = DEFAULT_YAC_QINDEX;
+  encoder->bitrate_bits = 0;

this is not needed since it is the default

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.