[Bug 762884] rtspsrc: allow to control headers via properties

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762884

--- Comment #34 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Matt Staples from comment #33)
> Review of attachment 344659 [details] [review]:
> 
> ::: gst/rtsp/gstrtspsrc.c
> @@ +431,3 @@
> +
> +  myboolean = g_value_get_boolean (handler_return);
> +
> 
> This was just a cut/paste from select_stream_accum, following the same
> pattern.  I'm not sure the debug message is needed here at all.  Ok to just
> remove it?

Sure

> @@ +5379,3 @@
> +  if (!allow_send) {
> +    GST_DEBUG_OBJECT (src, "skipping message, disabled by signal");
> +    return GST_RTSP_OK;
> 
> I'm not sure what you mean.  Should the signal handler take something other
> than the allow_send boolean?  like, (send, skip or error)?

Maybe let the signal return a GstRTSPResult

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.