[Bug 757563] audiomixer: issues with seamless looping (missing support for non-flushing seeks)
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Wed Nov 1 22:52:09 UTC 2017
https://bugzilla.gnome.org/show_bug.cgi?id=757563
--- Comment #8 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
Review of attachment 362753:
--> (https://bugzilla.gnome.org/review?bug=757563&attachment=362753)
Just gave a quick look, I'll try to give a more in-depth asap, at least on the
aggregator side :)
::: gst-libs/gst/base/gstaggregator.c
@@ +1567,3 @@
+
+ /* send whatever is in the mix buffer */
+ gst_aggregator_drain (self);
This should be done from the aggregate (srcpad) thread, not from a random
sinkpad's streaming thread :)
@@ +2140,3 @@
+ priv->segmented_seeking = segmented;
+ /* we apply the segment, once we have segment from all sources */
+ /* FIXME: do we need a queue of seek-events? */
If I understood what you told me at the conf correctly, yes ?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list