[Bug 789521] gstreamer-editing-services: GESAssets : Added function guards to avoid NULL pointer dereferencing

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sat Nov 4 10:32:58 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=789521

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk
 Attachment #362505|none                        |needs-work
             status|                            |

--- Comment #4 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 362505
  --> https://bugzilla.gnome.org/attachment.cgi?id=362505
[PATCH] gstreamer-editing-services: GESAssets : Added function guards to avoid
NULL pointer dereferencing

Thanks for the patches. However:

- Please make patches against a git checkout (you have an additional path
component in there that doesn't belong).

- There should be an empty newline after g_return_*if_fail() blocks.

- NULL is not a GType, use G_TYPE_NONE or G_TYPE_INVALID.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list