[Bug 789871] preset: Do not save deprecated properties

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=789871

--- Comment #3 from Thibault Saunier <tsaunier at gnome.org> ---
(In reply to Tim-Philipp Müller from comment #2)
> What will g_warn upon deserialisation? GstPreset? Some elements?

Usually elements do.

> Arguably there could be a backwards-compatibility issue here - if someone
> only set the old version of some property and doesn't set the new one then
> we're dropping the setting entirely, no?

Yeah, I know that - I am not sure what would be best in that case.

> Unless we assume that elements will always configure their new versions
> right when the deprecated ones get set. Which might be a reasonable
> assumption/requirement to make.
> 
> Either way it's probably fine, since hardly anyone uses presets anyway ;)

Right, this is somehow my view also... I am not 100% convinced by that patch
either tbh but I do not see what would be a good solution for that (we get
spanned by g_warning in Pitivi when using encoders that have deprecated props
(vp8 for example)).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.