[Bug 789902] value: Fix out-of-bound calculation

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sat Nov 4 12:32:30 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=789902

--- Comment #1 from Edward Hervey <bilboed at bilboed.com> ---
Created attachment 362957
  --> https://bugzilla.gnome.org/attachment.cgi?id=362957&action=edit
value: Fix out-of-bound calculation

This was introduced in 2001 by 39533f4364b7f3fd8b54f87039acebc705d68c3a
 "gstvalue: add stepped ranges"

The problem is that we could have a valid range with [0, MAXINT32]

And the resulting n1 and n2 values would be out of bound.

After reading the code, it seems as though that "+ 1" was not meant to
be there.

the various checks being done with those values are:
* if (n1 != n2) # having a +1 on both doesn't change anything
* if (n1 == 0)  # That would never be reached because of the +1
* if (n1 > 1) # commented as "if more than one value"

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list