[Bug 789847] msdkenc: Add support for YV12, YUY2, UYVY and BGRA

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=789847

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #363035|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 363035:
 --> (https://bugzilla.gnome.org/review?bug=789847&attachment=363035)

Still does not work, but some notes for later

::: sys/msdk/gstmsdkenc.c
@@ +393,3 @@
+    request[0].NumFrameSuggested =
+        MAX (request[0].NumFrameSuggested, request[1].NumFrameSuggested);
+  if (request[0].NumFrameSuggested < thiz->param.AsyncDepth) {

This should probably be 1 more if vpp

@@ +881,3 @@
+
+    /* Wait for VPP operation to complete */
+    MFXVideoCORE_SyncOperation (session, vpp_sync_point, 10000);

Instead of waiting for completion here, according to the encoding example from
the MediaSDK code, it would also be possible to directly encode it and the
encoder takes care of the waiting once needed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.