[Bug 776720] souphttpsrc: no request retry on early server termination

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Nov 8 15:37:37 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=776720

Edward Hervey <bilboed at bilboed.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bilboed at bilboed.com

--- Comment #14 from Edward Hervey <bilboed at bilboed.com> ---
fwiw, I just pushed a commit that fixed a regression introduced by this commit

commit 770bb07f3059a529a54a3fa3521da641afe25c5e (HEAD -> master, origin/master,
origin/HEAD)
Author: Edward Hervey <edward at centricular.com>
Date:   Wed Nov 8 16:34:01 2017 +0100

    souphttpsrc: Fix seeking back to 0

    This is a regression introduced by "03db374 - souphttpsrc: retry
    request on early termination from the server"

    The problem was that when seeking back to 0, we would not end up calling
    add_range_header() which in addition to adding range headers *ALSO* sets
    the read_position to the requested one.

    This would result in a wide variety of later failures, like reading
    again and again instead of stopping properly.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list