[Bug 790087] videodecoder: performance regression with libav decoders

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Nov 9 15:37:29 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=790087

--- Comment #5 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Ah, I see, indeed it will be shallow instead of hard copy. But then we need to
chase and remove all code the enable zero copy in sinks by checking:

   buffer->pool == my_pool

And check that the memory objects are correct, that the VideoMeta is still
supported etc. It's pretty hard and there is no generic code to check this. For
waylandsink, it will copy in a more creative way:

  wlbuffer = gst_buffer_get_wl_buffer (buffer);

Which grabs a cached wlbuffer from the original buffer quark, which won't be
copied by a shallow copy. So no, it won't fix it for waylandsink.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list