[Bug 779957] souphttpsrc: Manipulate range header when seek to 0

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Nov 10 09:23:43 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=779957

Edward Hervey <bilboed at bilboed.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
            Version|1.10.3                      |git master
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.13.1

--- Comment #11 from Edward Hervey <bilboed at bilboed.com> ---
I pushed the commit with the simplification.

commit b4edfb5998a7d9cc28e245ee4fe92720218450f1 (HEAD -> master)
Author: paul.kim <paul.hyunil at lge.com>
Date:   Mon Mar 13 18:14:12 2017 +0900

    souphttpsrc: Remove range header when seek to 0

    This fixes the previous range header is remained if seek to 0 is
    attempted.

    https://bugzilla.gnome.org/show_bug.cgi?id=779957

diff --git a/ext/soup/gstsouphttpsrc.c b/ext/soup/gstsouphttpsrc.c
index ff64d71c9..975692440 100644
--- a/ext/soup/gstsouphttpsrc.c
+++ b/ext/soup/gstsouphttpsrc.c
@@ -1580,7 +1580,8 @@ gst_soup_http_src_do_request (GstSoupHTTPSrc * src, const
gchar * method)
   if (src->msg && src->request_position > 0) {
     gst_soup_http_src_add_range_header (src, src->request_position,
         src->stop_position);
-  }
+  } else if (src->msg && src->request_position == 0)
+    soup_message_headers_remove (src->msg->request_headers, "Range");

   /* add_range_header() has the side effect of setting read_position to
    * the requested position. This *needs* to be set regardless of having

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list