[Bug 790007] decodebin2: Wait for cleanup thread to finish

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Nov 10 16:24:26 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=790007

Edward Hervey <bilboed at bilboed.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.13.1

--- Comment #5 from Edward Hervey <bilboed at bilboed.com> ---
commit 35a8d42724d5f9753fc18a7d27a7bf16993eed78
Author: Edward Hervey <edward at centricular.com>
Date:   Fri Nov 10 14:54:12 2017 +0100

    parsebin: Don't let thread run after unref

    We have a dedicated one-shot thread to handle cleanup of old groups.

    While this is a good idea. It's an even better idea to make sure
    that thread is *completed* before the parsebin element to which
    it is related isn't freed/gone.

    * There can only be one cleanup thread happening at any point in time.
      If there is already one, we wait for the previous one to finish.
    * When shutting down (NULL=>READY) make sure the thread is finished

    https://bugzilla.gnome.org/show_bug.cgi?id=790007

commit 43b9bcbddb6599fe05c1fafa3105412fedd07d23
Author: Edward Hervey <edward at centricular.com>
Date:   Fri Nov 10 14:54:12 2017 +0100

    decodebin2: Don't let thread run after unref

    We have a dedicated one-shot thread to handle cleanup of old groups.

    While this is a good idea. It's an even better idea to make sure
    that thread is *completed* before the decodebin2 element to which
    it is related isn't freed/gone.

    * There can only be one cleanup thread happening at any point in time.
      If there is already one, we wait for the previous one to finish.
    * When shutting down (NULL=>READY) make sure the thread is finished

    https://bugzilla.gnome.org/show_bug.cgi?id=790007

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list