[Bug 790057] waylandsink does not respect video alignment from upstream

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790057

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas at ndufresne.ca

--- Comment #3 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
To add more details, after:

+  wlbuffer = gst_buffer_get_wl_buffer (buffer);

We need to find a way to validate that the video meta (offsets and strides)
used to create that wl_buffer matches the what we have on this buffer. They
could in theory have changed. That is rarely the case, but I have plan to make
this happen more often ;-P


Then, a second bug in:

+ wbuf = gst_wl_shm_memory_construct_wl_buffer (mem, sink->display,
+          &sink->video_info);

The video_info has not yet been updated to match the GstBuffer video meta. In
the copy path it works because gst_video_frame_map() secretly update that
structure for us. An extra nice thing to do would be to add a helper in
gst_video library that just do that.

In GstVideoBufferPool, setting that alignment will simply call
gst_video_info_aling() on a VideoInfo structure cached in the buffer pool.
Because it's a opaque copy, we often end up being out-of-sync if we use it as
our internal pool.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.