[Bug 790412] unit test failure: rtspclientsink test_record fails with GST_MESSAGE_TYPE (msg) != GST_MESSAGE_EOS

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790412

--- Comment #18 from Patricia Muscalu <patricia at axis.com> ---
(In reply to Patricia Muscalu from comment #17)
> (In reply to Sebastian Dröge (slomo) from comment #16)
> > Also the udpsink destination in our case would have to be configured after
> > SETUP.
> > 
> > So _join_bin() should be called before SETUP (it is now, in _open()). And
> 
> Correct.
> 
> > _complete() should be called after all SETUPs to add the transport elements
> > (that's what it does, right?).
> 
> Yes, as long as we talk about the server side it's true.
> So when the stream part is provided by the client (client_side set on
> rtsp-stream) only the rtcp sending part is added to the stream in
> _complete_stream().
> "client_side" attribute should be probably changed to "receiving_mode":
> * in receiving_mode recv_rtcp_src pad of rtpbin is active and connected to
> depay 
> * in !receiving_mode send_rtp_src is active and connected to sender part
> (created in create_sender_part()).
> If this code is supposed to be called from the rtspclientsink, we need to
> introduce more complexity, because in this case we want to add the sender
> part connected to send_rtp_src (I tried to describe the idea of
> client/server mode in the text above).

_complete_stream() may actually work without any additonal changes as the
function (create_sender_part()) checks if we have priv->srcpad.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.