[Bug 790057] waylandsink does not respect video alignment from upstream

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Nov 21 02:54:46 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=790057

--- Comment #14 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Ok, the problem is that libav will still use the SHM allocator we have
proposed. It's a bit unfortunate, since we can't use that memory, but because
we offer it generically, we'll need to handle the case where we have FD memory
but the offsets introduce padding between planes.

For that, we'll need to extrapolate offsets and strides from the first strides
(so there is no padding) and compare against the provided array. Then, only if
that matches we'll be able to use it as SHM (exactly like DRM Dumb buffers,
which share the same poorly defined API, hence wastn't meant to be used with
planar formats). Overall, this will make our SHM support more robust. Arnaud's
patch didn't protect against an upstream element, that has it's own FdMemory
allocator to pass unsupported strides/offsets (I'm thinking about pipewire
here).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list