[Bug 790628] h264parse: put downstream caps first if possible on sink caps

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790628

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #364061|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 364061:
 --> (https://bugzilla.gnome.org/review?bug=790628&attachment=364061)

Generally looks good

::: gst/videoparsers/gsth264parse.c
@@ +2787,2 @@
   if (peercaps) {
+    GstCaps *pcopy = gst_caps_copy (peercaps);

This claims that peercaps can be NULL but they can't, right? The above code
always sets it to something, so if anything they might be empty but never NULL

@@ +2804,3 @@

+  /* Try if we can put the downstream caps first */
+  remove_fields (peercaps, FALSE);

... otherwise if they could be NULL, this would fail. So please remove the if
condition above, or otherwise there will be a coverity warning about this :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.