[Bug 773104] rtpbasedepayload: Drop gap events before first buffer

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Nov 21 13:54:54 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=773104

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk

--- Comment #6 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
There should already be an input segment at this point, so the main problem is
the caps event, right?

As far as I can tell, rtpjitterbuffer only sends packetlost events when it
detects that packets are actually lost. It won't send these for sparse streams,
an it won't send any if it doesn't receive packets initially.

The patch seems fine to me, but we could limit it to audio/video if needed, but
it's not clear to me that that's needed, as per above.

We know that muxers don't handle live inputs well. So any pipeline with
collectpads-based muxers is already pretty much broken for this use case, so
this particular patch won't make much difference to them.

Also, for most muxers it's more important to get accurate caps once, and
getting incomplete caps or changing caps later is a big no-no, so making up
some bogus caps seems very suboptimal for that use case.

We did make sure to pass through gap events so that e.g. audiosinks could
preroll and start up in cases where there's no audio at the beginning, but I
believe this is only relevant for non-live pipelines?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list