[Bug 790508] srtpenc calling srtp_protect_rtcp after session is deallocated

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790508

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #364112|accepted-commit_now         |reviewed
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 364112:
 --> (https://bugzilla.gnome.org/review?bug=790508&attachment=364112)

::: ext/srtp/gstsrtpenc.c
@@ +1045,3 @@
+      err = srtp_protect_rtcp (filter->session, mapout.data, &size);
+    else
+      err = srtp_protect (filter->session, mapout.data, &size);

Actually this does not seem correct. If there is no session, we would now send
data unencrypted, which is probably not the intention here, ever. It should
probably cause an error instead, or GST_FLOW_FLUSHING.

When exactly can this happen, what are all the situations?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.