[Bug 790762] rtpsession: do not report internal sources

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Nov 23 18:05:03 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=790762

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #364282|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 364282:
 --> (https://bugzilla.gnome.org/review?bug=790762&attachment=364282)

::: gst/rtpmanager/rtpsession.c
@@ +3420,3 @@

+  if (source->internal) {
+    GST_DEBUG ("source %08x not internal", source->ssrc);

There's a "not" too much here :)

The internal sources are the ones that we produce, right? So for a sender these
would be the ssrcs with which data is sent, and those should surely be included
here? And for a receiver they're the sources we use for sending RTCP?
Just trying to confirm that my memory is correct first.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list