[Bug 765275] matroska: implement reading & writing ContentEncryption headers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765275

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #361954|none                        |needs-work
             status|                            |

--- Comment #26 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 361954:
 --> (https://bugzilla.gnome.org/review?bug=765275&attachment=361954)

::: gst/matroska/matroska-mux.c
@@ +1051,3 @@
+
+  gst_structure_get_enum (structure, "signature-algorithm",
+      MATROSKA_TRACK_SIGNATURE_ALGORITHM_TYPE, &signature_algorithm);

Shouldn't encrypted content get its own caps type(s)? This looks now like it
supports the existing ones with additional fields, but using the existing ones
is wrong: the content is encrypted and unusable without previous decryption

In the demuxer you use a new caps type: "application/x-matroska-enc"

@@ +2334,3 @@
+    enc.sig_algo = signature_algorithm;
+
+    g_array_append_val (context->encodings, enc);

This code seems to be duplicated for each pad type, maybe move it to a
function?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.