[Bug 790686] matroskamux: re-activate TOC support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790686

--- Comment #7 from fengalin at free.fr ---
For the UID generation, I kept the behaviour of previous implementation which
seemed reasonable to me: considering that the UIDs have to be unique within the
container, I'm not sure it would be a good idea to rely on the user's input.
The function gst_matroska_mux_create_uid generates a UID in the expected range
and checks that it is not already used. The UIDs generation is not only used by
TOC entries, but also by Pads AFAICT. If you agree with this approach, I can
add a comment.

The reason why I didn't set the entry's UID back is that there is no setter for
UIDs on GstTocEntry. Do you want me to add it? You pointed to a bug in my
implementation as gst_matroska_mux_write_toc_entry_tags uses
gst_toc_entry_get_uid when writing tags. Either we add the setters, or I will
pass the generated UID to gst_matroska_mux_write_toc_entry_tags.

> "cur = g_list_first(toc_entries)" is the same as "cur = toc_entries" btw
Yes, you're right, I'll rationalize this.

> The to_write list seems to be never freed
Yes, you're right, I though I did the job by unrefing toc_edition_entry, but
that's not enough.

I'll change the unit test.

Can you give me your opinion about the UID setters? Should we add them, thus
changing the user provided UID on GstTocEntry?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.