[Bug 790762] rtpsession: do not report internal sources

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790762

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at coaxion.net

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Miguel París Díaz from comment #2)
> Hello Sebastian,
> I understand better (I hope for you too) the internal meaning considering:
>   - internal sources are related to LOCAL RTP SSRCs
>   - non-internal sources are related to REMOTE RTP SSRCs
> 
> Taking this into account:
>   - internal sources are created to send RTP packets or to be used as
> (sender-SSRC) in RR reports [1].
>   - non-internal sources are created to receive RTP packets.

And what's a "sender" (the field on the RTP source) in this context? Something
that actually sends RTP packets, and not just an RTCP sender? Is every "sender"
always an internal source?
I guess this should be documented in a comment in rtpsource.h next to those
fields. Would you mind making another commit for that?


I agree that RBs must only contain SSRCs from which packets were actually
received. It doesn't make any sense otherwise.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.