[Bug 790795] New: rtpsession: avoid computing the sources multiple times in the same RTCP cycle

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790795

            Bug ID: 790795
           Summary: rtpsession: avoid computing the sources multiple times
                    in the same RTCP cycle
    Classification: Platform
           Product: GStreamer
           Version: 1.8.3
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: mparisdiaz at gmail.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 364343
  --> https://bugzilla.gnome.org/attachment.cgi?id=364343&action=edit
rtpsession: avoid computing the sources multiple times in the same RTCP cycle

I come across a problem when RTCP is generated in an RtpSession with more than
1 internal&sender RtpSources that causes to add the same Report Blocks (RB) in
each RTCP SR packet generated per each internal&sender RtpSource.
Whit this behavior:
  - Bandwidth is wasted.
  - fraction-lost value is wrong (except in the RBs of the first SR) due to its
calculation is based in a previous state refreshed each time the RB is
generated, which should only take place once per RTCP cycle, not per each
internal&sender RtpSource in each RTCP cycle.

I am attaching a patch that fixes the issue and adds a test about it.
I think that the test could be improved using GstTestClock to crank RTCP
thread.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.